cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "T Jake Luciani (JIRA)" <>
Subject [jira] [Comment Edited] (CASSANDRA-9795) Fix cqlsh dtests on windows
Date Tue, 14 Jul 2015 04:03:04 GMT


T Jake Luciani edited comment on CASSANDRA-9795 at 7/14/15 4:02 AM:

Cassandra branch:
ccm branch:
dtest branch:

This change fixes 25 tests

was (Author: tjake):

Cassandra branch:
ccm branch:
dtest branch:

> Fix cqlsh dtests on windows
> ---------------------------
>                 Key: CASSANDRA-9795
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: T Jake Luciani
>            Assignee: T Jake Luciani
>             Fix For: 2.2.x
> There are a number of portability problems with python on win32 as I've learned over
the past few days.  
>   * Our use of multiprocess is broken in cqlsh for windows.  
> The code was passing self to the sub-process which on windows must be pickleable (it's
not).  So I refactored to be a class which is initialized in the parent.
> Also, when the windows process starts it needs to load our cqlsh as a module. So I moved
cqlsh -> and added a tiny wrapper for bin/cqlsh 
>   * Our use of strftime is broken on windows
> The default timezone information %z in strftime isn't valid on windows.  I added code
to the date format parser in C* to support windows timezone labels.
>   * We have a number of file access issues in dtest
>   * csv import/export is broken on windows and requires all file be opened with mode
'wb' or 'rb'
>   * CCM's use of popen required the univeral_newline=True flag to work on windows

This message was sent by Atlassian JIRA

View raw message