cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Eggleston (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9749) CommitLogReplayer continues startup after encountering errors
Date Thu, 09 Jul 2015 17:02:06 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620843#comment-14620843
] 

Blake Eggleston commented on CASSANDRA-9749:
--------------------------------------------

I agree with [~benedict]. If the CL has errors, I think the right thing to do would be to
refuse to startup and instruct the operator to remove the bad segment, restart, then run a
repair. Technically, the recovering node shouldn't participate in any paxos rounds until the
repair is complete either.

> CommitLogReplayer continues startup after encountering errors
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-9749
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9749
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Branimir Lambov
>             Fix For: 2.2.x
>
>
> There are a few places where the commit log recovery method either skips sections or
just returns when it encounters errors.
> Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298
> Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314
and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366
> Whether these are user-fixable or not, I think we should require more direct user intervention
(ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message