cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Resolved] (CASSANDRA-9705) Simplify some of 8099's concrete implementations
Date Thu, 23 Jul 2015 12:48:05 GMT


Sylvain Lebresne resolved CASSANDRA-9705.
    Resolution: Fixed

Yes, there were a few small problems with reading old sstables. I should have run those tests
but I forgot sorry. Anyway, took the liberty to directly fix those in commit [f713be4a|;a=commitdiff;h=f713be4a],
so closing again (if you still find upgrade tests that are broken, feel free to re-open, but
in that case please point me to which test is failing exactly cause the upgrade tests I've
used are all passing).

> Simplify some of 8099's concrete implementations
> ------------------------------------------------
>                 Key: CASSANDRA-9705
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0 beta 1
> As mentioned in the ticket comments, some of the concrete implementations (for Cell,
Row, Clustering, PartitionUpdate, ...) of the initial patch for CASSANDRA-8099 are more complex
than they should be (the use of flyweight is typically probably ill-fitted), which probably
has performance consequence. This ticket is to track the refactoring/simplifying those implementation
(mainly by removing the use of flyweights and simplifying accordingly).

This message was sent by Atlassian JIRA

View raw message