cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9701) Enforce simple << complex sort order more strictly and efficiently
Date Thu, 02 Jul 2015 06:31:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611551#comment-14611551
] 

Sylvain Lebresne commented on CASSANDRA-9701:
---------------------------------------------

+1 to that last version with 2 tiny nits/suggestions:
* I'd have simply called the variable {{comparisonOrder}} as it's not exactly the order of
the {{kind}}.
* Maybe a small comment for posterity. Something like "We want to sort definitions by both
their kind and whether they are simple or complex, and since that comparison is called on
hot code path we pre-compute the ordering".

> Enforce simple << complex sort order more strictly and efficiently
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-9701
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9701
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> A small refactor as follow up to 8099. By splitting SIMPLE and COMPLEX into their own
Kind, we can simplify the compareTo method and obtain greater certainty that we don't (now
or in future) accidentally break the required sort order that simple << complex.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message