cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9701) Split Kind.REGULAR into SIMPLE and COMPLEX
Date Wed, 01 Jul 2015 20:37:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610966#comment-14610966
] 

Benedict commented on CASSANDRA-9701:
-------------------------------------

That turned out to make the patch dramatically smaller. I opted to just, effectively, pre-compute
the sort order of the Kind + isComplex. Which makes it optimal and removes the risk of breaking
our sort order by accident later. Force pushed, and awaiting CI.

{noformat}
 src/java/org/apache/cassandra/config/ColumnDefinition.java | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
{noformat}

> Split Kind.REGULAR into SIMPLE and COMPLEX
> ------------------------------------------
>
>                 Key: CASSANDRA-9701
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9701
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> A small refactor as follow up to 8099. By splitting SIMPLE and COMPLEX into their own
Kind, we can simplify the compareTo method and obtain greater certainty that we don't (now
or in future) accidentally break the required sort order that simple << complex.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message