cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9656) Strong circular-reference leaks
Date Mon, 06 Jul 2015 10:26:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614837#comment-14614837
] 

Branimir Lambov commented on CASSANDRA-9656:
--------------------------------------------

The 2.1 version looks good.

In the 2.2 (Branch 9656-2.2 I presume? Your second link points to the same place.), {{testFileRemoval}}
no longer does truncation at the end, and the earlier version of {{testSSTableSplit}} checks
that a truncation is not actually performed in the offline case, while it now skips that call
altogether-- if that's a required change, [this comment|https://github.com/apache/cassandra/compare/trunk...belliottsmith:9656-2.2#diff-02c4b3ac06af7b36bb219956c41616f6R707]
should be changed. The rest looks good.

> Strong circular-reference leaks
> -------------------------------
>
>                 Key: CASSANDRA-9656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9656
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Critical
>             Fix For: 2.1.8
>
>
> As discussed in CASSANDRA-9423, we are leaking references to the ref-counted object into
the Ref.Tidy, so that they remain strongly reachable, significantly limiting the value of
the leak detection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message