cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9265) Add checksum to saved cache files
Date Mon, 27 Jul 2015 15:05:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642831#comment-14642831
] 

Ariel Weisberg commented on CASSANDRA-9265:
-------------------------------------------

If I recall correctly it throws out the old caches on version changes whether you need it
or not. We are also breaking the format for saved caches in 3.0 anyways because of the vint
coding changes. Now is a very good time to add a per record checksum.

> Add checksum to saved cache files
> ---------------------------------
>
>                 Key: CASSANDRA-9265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9265
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>             Fix For: 3.x
>
>
> Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion
is a large checksum of the whole file (convenient offline validation), and then smaller per
record checksums after each record is written (possibly a subset of the incrementally maintained
larger checksum).
> I wouldn't go for anything fancy to try to recover from corruption since it is just a
saved cache. If corruption is detected while reading I would just have it bail out. I would
rather have less code to review and test in this instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message