cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-8413) Bloom filter false positive ratio is not honoured
Date Sun, 05 Jul 2015 13:57:04 GMT


Benedict commented on CASSANDRA-8413:

LGTM, especially like that you've gone to the effort of testing serialization across versions
in unit tests. 

Let's ship it once we get CI approval.

> Bloom filter false positive ratio is not honoured
> -------------------------------------------------
>                 Key: CASSANDRA-8413
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Robert Stupp
>             Fix For: 3.x
>         Attachments: 8413-patch.txt, 8413.hack-3.0.txt, 8413.hack.txt
> Whilst thinking about CASSANDRA-7438 and hash bits, I realised we have a problem with
sabotaging our bloom filters when using the murmur3 partitioner. I have performed a very quick
test to confirm this risk is real.
> Since a typical cluster uses the same murmur3 hash for partitioning as we do for bloom
filter lookups, and we own a contiguous range, we can guarantee that the top X bits collide
for all keys on the node. This translates into poor bloom filter distribution. I quickly hacked
LongBloomFilterTest to simulate the problem, and the result in these tests is _up to_ a doubling
of the actual false positive ratio. The actual change will depend on the key distribution,
the number of keys, the false positive ratio, the number of nodes, the token distribution,
etc. But seems to be a real problem for non-vnode clusters of at least ~128 nodes in size.

This message was sent by Atlassian JIRA

View raw message