Return-Path: 
 <commits-return-133789-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7FACD10C9C
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Wed,  3 Jun 2015 06:53:50 +0000 (UTC)
Received: (qmail 39824 invoked by uid 500); 3 Jun 2015 06:53:50 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 39783 invoked by uid 500); 3 Jun 2015 06:53:50 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 39624 invoked by uid 99); 3 Jun 2015 06:53:49 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 06:53:49 +0000
Date: Wed, 3 Jun 2015 06:53:49 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12834943.1433313175000.6035.1433314429858@Atlassian.JIRA>
In-Reply-To: <JIRA.12834943.1433313175000@Atlassian.JIRA>
References: <JIRA.12834943.1433313175000@Atlassian.JIRA>
 <JIRA.12834943.1433313175420@arcas>
Subject: [jira] [Commented] (CASSANDRA-9537) Sstables created with
 MockSchema occasionally triggers assertions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CASSANDRA-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570383#comment-14570383 ] 

Benedict commented on CASSANDRA-9537:
-------------------------------------

LGTM. Once CI runs I'll commit

> Sstables created with MockSchema occasionally triggers assertions
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-9537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9537
>             Project: Cassandra
>          Issue Type: Test
>          Components: Tests
>            Reporter: Stefania
>            Assignee: Stefania
>              Labels: test-failure
>             Fix For: 2.2.x
>
>
> It's extremely hard to reproduce but occasionally some Jenkins tests fail as follows:
> http://cassci.datastax.com/job/trunk_utest/229/testReport/org.apache.cassandra.db.lifecycle/TrackerTest/testAddInitialSSTables/
> {code}
> junit.framework.AssertionFailedError
> 	at org.apache.cassandra.utils.concurrent.Ref$State.assertNotReleased(Ref.java:157)
> 	at org.apache.cassandra.utils.concurrent.Ref.ref(Ref.java:113)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader$GlobalTidy.get(SSTableReader.java:2111)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader$DescriptorTypeTidy.<init>(SSTableReader.java:1980)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader$DescriptorTypeTidy.get(SSTableReader.java:2017)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader$InstanceTidier.setup(SSTableReader.java:1897)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader.setup(SSTableReader.java:1842)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader.internalOpen(SSTableReader.java:530)
> 	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:128)
> 	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:92)
> 	at org.apache.cassandra.MockSchema.sstable(MockSchema.java:87)
> 	at org.apache.cassandra.db.lifecycle.TrackerTest.testAddInitialSSTables(TrackerTest.java:146)
> {code}
> I propose not to reuse cfname in MockSchema.sstable() and in fact to get rid of the shared MockSchema.cfs which has caused other test problems, see CASSANDRA-9514.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)