Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C34E1825A for ; Fri, 5 Jun 2015 21:02:01 +0000 (UTC) Received: (qmail 10205 invoked by uid 500); 5 Jun 2015 21:02:01 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 10177 invoked by uid 500); 5 Jun 2015 21:02:01 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 10165 invoked by uid 99); 5 Jun 2015 21:02:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 21:02:01 +0000 Date: Fri, 5 Jun 2015 21:02:00 +0000 (UTC) From: "Ariel Weisberg (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9462) ViewTest.sstableInBounds is failing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575216#comment-14575216 ] Ariel Weisberg commented on CASSANDRA-9462: ------------------------------------------- I have something for this. It's not done. At the very least I want to add tests for the additional and involved functionality in this ticket I a still getting a handle on what the correct behavior for these things is. I need to take a look at unwrap to see if it is supposed to work differently for different kinds of inclusive/exclusive combinations. https://github.com/apache/cassandra/compare/trunk...aweisberg:C-9462?expand=1 > ViewTest.sstableInBounds is failing > ----------------------------------- > > Key: CASSANDRA-9462 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9462 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Benedict > Assignee: Ariel Weisberg > Fix For: 3.x, 2.1.x, 2.2.x > > > CASSANDRA-8568 introduced new tests to cover what was DataTracker functionality in 2.1, and is now covered by the lifecycle package. This particular test indicates this method does not fulfil the expected contract, namely that more sstables are returned than should be. > However while looking into it I noticed it also likely has a bug (which I have not updated the test to cover) wherein a wrapped range will only yield the portion at the end of the token range, not the beginning. It looks like we may have call sites using this function that do not realise this, so it could be a serious bug, especially for repair. -- This message was sent by Atlassian JIRA (v6.3.4#6332)