cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9586) ant eclipse-warnings fails in trunk
Date Fri, 12 Jun 2015 08:46:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583155#comment-14583155
] 

Stefania commented on CASSANDRA-9586:
-------------------------------------

It's a false warning because it is released in close(). 

Making the wrapper auto closeable does not fix it. Passing in a channel that is closed in
a try and taking a new reference in the constructor fixes it however.

> ant eclipse-warnings fails in trunk
> -----------------------------------
>
>                 Key: CASSANDRA-9586
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9586
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Michael Shuler
>            Assignee: Stefania
>             Fix For: 3.x
>
>
> {noformat}
> eclipse-warnings:
>     [mkdir] Created dir: /home/mshuler/git/cassandra/build/ecj
>      [echo] Running Eclipse Code Analysis.  Output logged to /home/mshuler/git/cassandra/build/ecj/eclipse_compiler_checks.txt
>      [java] incorrect classpath: /home/mshuler/git/cassandra/build/cobertura/classes
>      [java] ----------
>      [java] 1. ERROR in /home/mshuler/git/cassandra/src/java/org/apache/cassandra/io/util/RandomAccessReader.java
(at line 81)
>      [java]     super(new ChannelProxy(file), DEFAULT_BUFFER_SIZE, -1L, BufferType.OFF_HEAP);
>      [java]           ^^^^^^^^^^^^^^^^^^^^^^
>      [java] Potential resource leak: '<unassigned Closeable value>' may not be
closed
>      [java] ----------
>      [java] 1 problem (1 error)
> BUILD FAILED
> {noformat}
> (checked 2.2 and did not find this issue)
> git blame on line 81 shows commit 17dd4cc for CASSANDRA-8897



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message