cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-9581) pig-tests spend time waiting on /dev/random for SecureRandom
Date Thu, 11 Jun 2015 19:06:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582379#comment-14582379
] 

Ariel Weisberg edited comment on CASSANDRA-9581 at 6/11/15 7:05 PM:
--------------------------------------------------------------------

This seems to shave anywhere between 1 and 4 minutes off of pig-test. At it's fastest pig-test
is 4 minutes 30 seconds so worth the one line IMO. We also benefit down the road if any other
unit tests end up needing to get seed data.

You can see the JDK plumbing behind this here
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/sun/security/provider/SeedGenerator.java?av=f#91
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/sun/security/provider/SunEntries.java?av=f#309

Proposed change https://github.com/apache/cassandra/compare/trunk...aweisberg:C-9581


was (Author: aweisberg):
This seems to shave anywhere between 1 and 4 minutes off of pig-test. At it's fastest pig-test
is 4 minutes 30 seconds so worth the one line IMO. We also benefit down the road if any other
unit tests end up needing to get seed data.

> pig-tests spend time waiting on /dev/random for SecureRandom
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-9581
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9581
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>
> We don't need secure random numbers (for unit tests) so waiting for entropy doesn't make
much sense. Luckily Java makes it easy to point to /dev/urandom for entropy. It also transparently
handles it correctly on Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message