cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Thompson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9576) Connection leak in CQLRecordWriter
Date Mon, 15 Jun 2015 16:09:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586246#comment-14586246
] 

Philip Thompson commented on CASSANDRA-9576:
--------------------------------------------

The problem is I missed that when we break, we're resetting the inner loop. The close is only
happening at the end of the outer loop. This is actually really serious. I've reordered those
two blocks, and am running the patch on cassci.

> Connection leak in CQLRecordWriter
> ----------------------------------
>
>                 Key: CASSANDRA-9576
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9576
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Hadoop
>            Reporter: T Meyarivan
>            Assignee: Philip Thompson
>             Fix For: 2.2.0 rc2
>
>
> Ran into connection leaks when using CQLCassandra apache-cassandra-2.2.0-beta1-src +
CQLOutputFormat (via CqlNativeStorage). 
> It seems like the order blocks of code starting at https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/hadoop/cql3/CqlRecordWriter.java#L298
were reversed in 2.2 which leads to the connection leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message