cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9570) Deprecated forceRepairAsync methods in StorageService do not work
Date Wed, 10 Jun 2015 00:52:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579814#comment-14579814
] 

Yuki Morishita commented on CASSANDRA-9570:
-------------------------------------------

Patch here: https://github.com/yukim/cassandra/tree/9570
dtest added to test deprecated repair JMX API: https://github.com/yukim/cassandra-dtest/tree/deprecated_repair_test
(pull request: https://github.com/riptano/cassandra-dtest/pull/317)

> Deprecated forceRepairAsync methods in StorageService do not work
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-9570
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9570
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Mike Adamson
>            Assignee: Yuki Morishita
>             Fix For: 2.2.0 rc2
>
>
> The deprecated forceRepairAsync methods in StorageService don't work because they are
creating RepairOption as follows:
> {noformat}
>         RepairOption options = new RepairOption(parallelism, primaryRange, !fullRepair,
false, 1, Collections.<Range<Token>>emptyList());
> {noformat}
> This creates a RepairOption with an empty token range. The methods call down to:
> {noformat}
>     public int forceRepairAsync(String keyspace, RepairOption options)
>     {
>         if (options.getRanges().isEmpty() || Keyspace.open(keyspace).getReplicationStrategy().getReplicationFactor()
< 2)
>             return 0;
>         int cmd = nextRepairCommand.incrementAndGet();
>         new Thread(createRepairTask(cmd, keyspace, options)).start();
>         return cmd;
>     }
> {noformat}
> to run the repair and this returns 0 because option ranges are empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message