cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9496) ArrivalWindow should use primitives
Date Wed, 17 Jun 2015 21:42:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590665#comment-14590665
] 

Jason Brown commented on CASSANDRA-9496:
----------------------------------------

+1, looks good. I also took the liberty of removing BoundedStatsDeque and it's test as they
are no longer used after this change.

Commited to 2.0, 2.1, 2.2, and trunk. Thanks!

> ArrivalWindow should use primitives 
> ------------------------------------
>
>                 Key: CASSANDRA-9496
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9496
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: sankalp kohli
>            Assignee: sankalp kohli
>            Priority: Minor
>         Attachments: 9496.txt
>
>
> While doing a heap analysis of a large cluster(1000+), I found that majority of the strongly
referenced objects on heap are coming from ArrivalWindow. 
> Currently ArrivalWindow uses BoundedStatsDeque which uses LinkedBlockingDeque<Long>
deque. 
> For a cluster of size 1000, it will translate into 2 million objects. 
> We can use primitives and use an array of long(long[]). This will cut down on the number
of objects and the change is not that big. 
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message