cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvestor George (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (CASSANDRA-9293) Unit tests should fail if any LEAK DETECTED errors are printed
Date Tue, 09 Jun 2015 22:07:01 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvestor George updated CASSANDRA-9293:
----------------------------------------
    Comment: was deleted

(was: Hi,

I have added 2 functions to check before and after count of leak detection errors for every
unit test. If the after count is more than the before count for a specific unit test, the
test fails with message 'Leak Detected for this test.'

Please let me know if I am on the right track or is there an better alternate to incorporate
this.

Thanks,
Sylvestor George)

> Unit tests should fail if any LEAK DETECTED errors are printed
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-9293
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9293
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Philip Thompson
>              Labels: test
>         Attachments: 9293.txt
>
>
> We shouldn't depend on dtests to inform us of these problems (which have error log monitoring)
- they should be caught by unit tests, which may also cover different failure conditions (besides
being faster).
> There are a couple of ways we could do this, but probably the easiest is to add a static
flag that is set to true if we ever see a leak (in Ref), and to just assert that this is false
at the end of every test.
> [~enigmacurry] is this something TE can help with?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message