cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvestor George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9293) Unit tests should fail if any LEAK DETECTED errors are printed
Date Thu, 25 Jun 2015 20:08:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601839#comment-14601839
] 

Sylvestor George commented on CASSANDRA-9293:
---------------------------------------------

Yes. It looks for the logs from previous test, and checks if any new LEAK DETECTED for that
test class.  If a leak is detected, the added test fails. 

I will further look into detecting the error from the files you have mentioned above.

> Unit tests should fail if any LEAK DETECTED errors are printed
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-9293
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9293
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Sylvestor George
>              Labels: test
>         Attachments: 9293.txt
>
>
> We shouldn't depend on dtests to inform us of these problems (which have error log monitoring)
- they should be caught by unit tests, which may also cover different failure conditions (besides
being faster).
> There are a couple of ways we could do this, but probably the easiest is to add a static
flag that is set to true if we ever see a leak (in Ref), and to just assert that this is false
at the end of every test.
> [~enigmacurry] is this something TE can help with?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message