cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9271) IndexSummaryManagerTest.testCompactionRace times out periodically
Date Mon, 01 Jun 2015 16:47:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567557#comment-14567557
] 

Benedict commented on CASSANDRA-9271:
-------------------------------------

It may fix this behaviour, but unfortunately I am -1 on using Thread.yield(). It depends on
the priority of the thread, and that is generally not good practice. It could lead to spinning
burning a full CPU flat out until compactions acquiesce. I don't like making application behaviour
even slightly less good in order to fix a problematic test.

As I stated above, it should be possible to modify this test to simply mark and unmark compacting
directly, rather than actually perform a major compaction.

> IndexSummaryManagerTest.testCompactionRace times out periodically
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-9271
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9271
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>            Priority: Trivial
>              Labels: test-failure
>             Fix For: 2.1.6
>
>
> The issue is that the amount of time the test takes is highly variable to it being biased
towards creating a condition where the test has to retry the compaction it is attempting.
> Solution is to decrease the bias by having https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L2522
check every millisecond instead of every 100 milliseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message