cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9160) Migrate CQL dtests to unit tests
Date Tue, 09 Jun 2015 18:54:03 GMT


Joshua McKenzie commented on CASSANDRA-9160:

Part 2:
- TableTest.testDate looks like it would fit better in a DateTypeTest (similar to SimpleDateTypeTest),
though there's no class created to test that as yet.
Remove comment in TableTest.testDeletion re: 3708
- TableTest.testLimitInCompactTable: While the comment and commented code there is a direct
port from the dtest, what purpose is it serving by leaving it in?
- TableTest.testRangeSlice should be left as the cql_tests:range_slice_test since it looks
like it requires 2 nodes to exhibit the problem that CASSANDRA-1337 resolves.
- TableTest.testTable: commented code brought over from dtest. Either make valid or remove.
- TableTest.testTimeuuid: might want to a) move the comment at the end up above the code it's
referencing and b) either remove it or beef up the test by checking other things and then
remove it. You're going to be associated with this code in annotation in the future so it's
probably best to clear up things like that rather than us having to dig into history on old
dtest SHA's and figure out who originally wrote the comment.
- TableTest.testTokenRange: remove commented code

The removal and additions on the dtest branch look good thus far; ready to review once the
StorageProxy and #TODO in there are worked out.

> Migrate CQL dtests to unit tests
> --------------------------------
>                 Key: CASSANDRA-9160
>                 URL:
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Sylvain Lebresne
>            Assignee: Stefania
> We have CQL tests in 2 places: dtests and unit tests. The unit tests are actually somewhat
better in the sense that they have the ability to test both prepared and unprepared statements
at the flip of a switch. It's also better to have all those tests in the same place so we
can improve the test framework in only one place (CASSANDRA-7959, CASSANDRA-9159, etc...).
So we should move the CQL dtests to the unit tests (which will be a good occasion to organize
them better).

This message was sent by Atlassian JIRA

View raw message