Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 26 May 2015 13:12:18 +0000 (UTC)
From: =?utf-8?Q?Cl=C3=A9ment_Lardeur_=28JIRA=29?= <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12832601.1432609582000.26551.1432645938770@Atlassian.JIRA>
In-Reply-To: <JIRA.12832601.1432609582000@Atlassian.JIRA>
References: <JIRA.12832601.1432609582000@Atlassian.JIRA>
 <JIRA.12832601.1432609582754@arcas>
Subject: [jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with
 non-zero status on failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cl=C3=A9ment Lardeur updated CASSANDRA-9477:
---------------------------------------
    Attachment: cassandra-2.1-9477.patch

Throw a runtime exception and exit with non-zero status code when JMX comma=
nd has failed.

> nodetool repair should exit with non-zero status on failure
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-9477
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9477
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Randy Fradin
>            Assignee: Cl=C3=A9ment Lardeur
>            Priority: Minor
>             Fix For: 2.1.x
>
>         Attachments: cassandra-2.1-9477.patch
>
>
> Previously nodetool repair would exit with a non-zero status code when it=
 experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being d=
own or a failed stream. It appears this is no longer the case, which makes =
it a bit harder to automate repair. I suspect it's been this way since CASS=
ANDRA-6381 was implemented, and that it probably affects other nodetool com=
mands as well.
> It looks like NodeProbe tracks when a failure occurs and this is accessib=
le via NodeProbe.isFailed(), but that value is not being used anywhere. I t=
hink the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after=
 the execute function is called, probe.isFailed() is checked and a RuntimeE=
xception is thrown if a failure has occurred.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)