Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E6FC1768E for ; Tue, 19 May 2015 22:11:00 +0000 (UTC) Received: (qmail 51561 invoked by uid 500); 19 May 2015 22:11:00 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 51518 invoked by uid 500); 19 May 2015 22:11:00 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 51500 invoked by uid 99); 19 May 2015 22:11:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 22:11:00 +0000 Date: Tue, 19 May 2015 22:11:00 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9431) Static Analysis to warn on unsafe use of Autocloseable instances MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551335#comment-14551335 ] Benedict commented on CASSANDRA-9431: ------------------------------------- My (out of date) experience with ecj (back in the days of 1.6 and 1.7 language features being introduced) was that ecj was actually always much more solid than javac on handling edge cases in the language. However I agree that we should stick to javac for compilation, as I would not want to risk weird bytecode production, which is much more important. > Static Analysis to warn on unsafe use of Autocloseable instances > ---------------------------------------------------------------- > > Key: CASSANDRA-9431 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9431 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: T Jake Luciani > Fix For: 3.0 beta 1 > > > The ideal goal would be to fail the build under any unsafe (and not annotated as considered safe independently) uses of Autocloseable. It looks as though eclipse (and hence, hopefully ecj) has support for this feature, so we should investigate if it meets our requirements and we can get it integrated -- This message was sent by Atlassian JIRA (v6.3.4#6332)