Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3935D17A84 for ; Thu, 14 May 2015 19:43:01 +0000 (UTC) Received: (qmail 43567 invoked by uid 500); 14 May 2015 19:43:01 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 43532 invoked by uid 500); 14 May 2015 19:43:01 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 43517 invoked by uid 99); 14 May 2015 19:43:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 19:43:01 +0000 Date: Thu, 14 May 2015 19:43:00 +0000 (UTC) From: "Tyler Hobbs (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9366) make Functions.declared thread-safe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544249#comment-14544249 ] Tyler Hobbs commented on CASSANDRA-9366: ---------------------------------------- +1, with one minor nit that you can fix on commit: in {{Functions.declare()}}, move the variable assignment outside of the method call. > make Functions.declared thread-safe > ----------------------------------- > > Key: CASSANDRA-9366 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9366 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Robert Stupp > Assignee: Robert Stupp > Fix For: 2.2.x > > Attachments: 9366.txt > > > {{Functions.declared}} is an {{ArrayListMultimap}}, which is not thread safe. > This wasn't a problem before UDFs. But with UDFs there can be concurrent reads & writes. > Need to make it thread safe. -- This message was sent by Atlassian JIRA (v6.3.4#6332)