Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B05E118327 for ; Mon, 4 May 2015 20:00:08 +0000 (UTC) Received: (qmail 99423 invoked by uid 500); 4 May 2015 20:00:08 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 99392 invoked by uid 500); 4 May 2015 20:00:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99379 invoked by uid 99); 4 May 2015 20:00:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2015 20:00:08 +0000 Date: Mon, 4 May 2015 20:00:08 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9282) Warn on unlogged batches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527166#comment-14527166 ] Jonathan Ellis commented on CASSANDRA-9282: ------------------------------------------- I was thinking we'd want to do this in StorageProxy to handle Thrift as well as CQL, but on second thought I am okay doing it for CQL only. Presumably Thrift users already have the scars from this and have learned their lesson by now. However, it would be useful to get a little more out of the warning message, and to give people a pointer to the right fix. {{Unlogged batch covering 100 partitions detected, starting with INSERT INTO USERS. You probably want to use a logged batch for atomicity, or asynchronous writes for performance.}} > Warn on unlogged batches > ------------------------ > > Key: CASSANDRA-9282 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9282 > Project: Cassandra > Issue Type: Bug > Components: API > Reporter: Jonathan Ellis > Assignee: T Jake Luciani > Fix For: 2.1.x > > > At least until CASSANDRA-8303 is done and we can block them entirely, we should log a warning when unlogged batches across multiple partition keys are used. This could either be done by backporting NoSpamLogger and blindly logging every time, or we could add a threshold and warn when more than 10 keys are seen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)