cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9457) Empty INITCOND treated as null in aggregate
Date Mon, 25 May 2015 17:42:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558407#comment-14558407
] 

Robert Stupp commented on CASSANDRA-9457:
-----------------------------------------

Need to special case for empty values. Reason is that we cannot be sure, that a value is never
empty (for types like {{int}}, {{timestamp}} etc).

Patch does the following:
* empty INITCOND rejected with an exception
* empty arguments are treated as null
* allow empty values for text/ascii/blob

Currently waiting for cassci builds:
[testall #2|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-9457-udf-empty-string-testall/2/]
[dtest #2|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-9457-udf-empty-string-dtest/2/]

> Empty INITCOND treated as null in aggregate
> -------------------------------------------
>
>                 Key: CASSANDRA-9457
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9457
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Olivier Michallat
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 2.2.0 rc1
>
>
> Given the following test data:
> {code}
> cqlsh:test> create table foo(k int, v int, primary key(k,v));
> cqlsh:test> insert into foo(k,v) values(1,1);
> cqlsh:test> insert into foo(k,v) values(1,2);
> cqlsh:test> insert into foo(k,v) values(1,3);
> {code}
> And the following aggregate definition:
> {code}
> cqlsh:test> CREATE FUNCTION cat(s text, v int)
>             RETURNS NULL ON NULL INPUT
>             RETURNS text 
>             LANGUAGE java
>             AS 'return s + v;';
> cqlsh:test> CREATE AGGREGATE cats(int) SFUNC cat STYPE text INITCOND '';
> {code}
> The following should return '123', but it returns null:
> {code}
> cqlsh:test> select cats(v) from foo where k = 1;
>  test.cats(v)
> ---------------
> {code}
> The empty INITCOND is treated as null, and the SFUNC is never called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message