cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9431) Static Analysis to warn on unsafe use of Autocloseable instances
Date Wed, 27 May 2015 16:14:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561208#comment-14561208
] 

Benedict commented on CASSANDRA-9431:
-------------------------------------

Did you see the comment I made on your github? I meant to collect them all in a List, and
close them only once all of the futures have successfully (or _all_ unsuccessfully_ terminated.
Since we're passing them off to another thread we cannot use a try/finally block, but we should
make certain they're closed regardless of what the runnable does with them...

> Static Analysis to warn on unsafe use of Autocloseable instances
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-9431
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9431
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: T Jake Luciani
>             Fix For: 2.2.0 rc1
>
>
> The ideal goal would be to fail the build under any unsafe (and not annotated as considered
safe independently) uses of Autocloseable. It looks as though eclipse (and hence, hopefully
ecj) has support for this feature, so we should investigate if it meets our requirements and
we can get it integrated



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message