cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9422) SystemKeyspaceTest fails with non-release version string
Date Wed, 20 May 2015 08:44:00 GMT


Sam Tunnicliffe commented on CASSANDRA-9422:

The only place we do that is in {{AntiCompactionTask}} where we have an appropriate null check
to handle an unparseable string. The code being tested here needs to do a simple string comparison
so we make sure we snapshot even when there's garbage/nothing in {{system.local}} at startup.
The test only uses {{SemanticVersion}} as a convenience so I prefer fixing the test to match
the actual implementation.

FTR, it's only the 'double barrelled' postfix that the issue here. i.e. {{-SNAPSHOT}}, {{-beta1}},
{{-RC1}} are all fine, but {{-beta1-SNAPSHOT}} isn't a valid semver. 

> SystemKeyspaceTest fails with non-release version string
> --------------------------------------------------------
>                 Key: CASSANDRA-9422
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 2.2.0 rc1
> {{SystemKeyspaceTest#snapshotSystemKeyspaceIfUpgrading}} is currently failing on the
2.2 branch because the build version {{2.2.0-beta1-SNAPSHOT}} cannot be parsed as a {{SemanticVersion}}.
This is only a problem with the test, as the code under test doesn't actually use {{SemanticVersion}},
it just checks whether the old & new version strings are different.

This message was sent by Atlassian JIRA

View raw message