cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9299) Fix counting of tombstones towards TombstoneOverwhelmingException
Date Tue, 12 May 2015 18:36:02 GMT


Aleksey Yeschenko commented on CASSANDRA-9299:

Thanks, committed as {{bed42c2104ebaac83da4292703c08a5c963e062c}}, with the comment fixed
in 2.1 and trunk.

{{paging_test.TestPagingWithDeletions.test_failure_threshold_deletions()}} was already failing,
although for a different reason, so I haven't noticed it at first. Anyway, updated the test
as well in

> Fix counting of tombstones towards TombstoneOverwhelmingException
> -----------------------------------------------------------------
>                 Key: CASSANDRA-9299
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.1.x, 2.0.x
>         Attachments: 9299-2.0.txt, 9299-2.1.txt, 9299-trunk.txt
> CASSANDRA-6042 introduced warning on too many tombstones scanned, then CASSANDRA-6117
introduced a hard TombstoneOverwhelmingException condition.
> However, at least {{SliceQuerFilter.collectReducedColumn()}} seems to have the logic
wrong. Cells that are covered by a range tombstone or a partition high level deletion, still
count towards {{ColumnCounter}}'s {{ignored}} register.
> Thus it's possible to have an otherwise healthy (though large) dropped partition read
cause an exception that shouldn't be there.
> The only things that should count towards the exception are cell tombstones and range
tombstones (CASSANDRA-8527), but never ever live cells shadowed by any kind of tombstone.

This message was sent by Atlassian JIRA

View raw message