cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8897) Remove FileCacheService, instead pooling the buffers
Date Thu, 14 May 2015 08:26:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543376#comment-14543376
] 

Benedict commented on CASSANDRA-8897:
-------------------------------------

[~stef1927]: It looks to me like we can simply stop calling channel.sharedCopy() in the constructor:
since these objects aren't pooled anymore, their lifetimes should be not a problem, and should
be guarded by the normal OpOrder or SSTableReader ref counting pathways. Taking a reference
to each reader is something we explicitly wanted to avoid by the introduction of the OpOrder,
so we should avoid it here as well.

However, it is something that's bugged me that we use a CLQ in Ref, and I've filed CASSANDRA-9379
to discuss updating this. As mentioned there, I prefer to avoid CHM or NBHM.

> Remove FileCacheService, instead pooling the buffers
> ----------------------------------------------------
>
>                 Key: CASSANDRA-8897
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8897
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Stefania
>             Fix For: 3.x
>
>         Attachments: 9240_test_results.txt, snapshot-1431582436640-cpu-backtraces.png,
snapshot-1431582436640-cpu-calltree-compression-8897.nps, snapshot-1431582436640-cpu-calltree-compression-trunk.nps
>
>
> After CASSANDRA-8893, a RAR will be a very lightweight object and will not need caching,
so we can eliminate this cache entirely. Instead we should have a pool of buffers that are
page-aligned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message