cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-8717) Top-k queries with custom secondary indexes
Date Wed, 06 May 2015 18:20:02 GMT


Sam Tunnicliffe updated CASSANDRA-8717:
    Attachment: 8717-follow-up-2.1.txt

The regression is caused by a {{StorageProxy#trim}} being incorrectly ported to {{AbstractRangeCommand}}.
The additional check of {{ignoredTombstonedPartitions()}} introduced by CASSANDRA-8490 was
omitted, causing a tombstoned partition in the results to be counted towards the limit. I've
attached a patch to fix it & have pushed test branches to my repo:

Cassci should pick these up and validate them shortly, at which point they'll appear here:

> Top-k queries with custom secondary indexes
> -------------------------------------------
>                 Key: CASSANDRA-8717
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Andrés de la Peña
>            Assignee: Andrés de la Peña
>            Priority: Minor
>              Labels: 2i, secondary_index, sort, sorting, top-k
>             Fix For: 2.1.6
>         Attachments: 0001-Add-support-for-top-k-queries-in-2i.patch, 0002-Add-support-for-top-k-queries-in-2i.patch,
0003-Add-support-for-top-k-queries-in-2i.patch, 0004-Add-support-for-top-k-queries-in-2i.patch,
8717-follow-up-2.1.txt, 8717-v5.txt
> As presented in [Cassandra Summit Europe 2014|],
secondary indexes can be modified to support general top-k queries with minimum changes in
Cassandra codebase. This way, custom 2i implementations could provide relevance search, sorting
by columns, etc.
> Top-k queries retrieve the k best results for a certain query. That implies querying
the k best rows in each token range and then sort them in order to obtain the k globally best
> For doing that, we propose two additional methods in class SecondaryIndexSearcher:
> {code:java}
> public boolean requiresFullScan(List<IndexExpression> clause)
> {
>     return false;
> }
> public List<Row> sort(List<IndexExpression> clause, List<Row> rows)
> {
>     return rows;
> }
> {code}
> The first one indicates if a query performed in the index requires querying all the nodes
in the ring. It is necessary in top-k queries because we do not know which node are the best
results. The second method specifies how to sort all the partial node results according to
the query. 
> Then we add two similar methods to the class AbstractRangeCommand:
> {code:java}
>     this.searcher =;
> public boolean requiresFullScan() {
>     return searcher == null ? false : searcher.requiresFullScan(rowFilter);
> }
> public List<Row> combine(List<Row> rows)
> {
>     return searcher == null ? trim(rows) : trim(searcher.sort(rowFilter, rows));
> }
> {code}
> Finnally, we modify StorageProxy#getRangeSlice to use the previous method, as shown in
the attached patch.
> We think that the proposed approach provides very useful functionality with minimum impact
in current codebase.

This message was sent by Atlassian JIRA

View raw message