cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Fri, 01 May 2015 13:23:06 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523181#comment-14523181
] 

Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------

It looks like the commit log sync is scope-creep (on a ticket that's already been extended
pretty far by scope creep). Maybe work that separately?

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Ariel Weisberg
>            Priority: Trivial
>             Fix For: 2.1.x
>
>         Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message