cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Fri, 01 May 2015 10:49:06 GMT


Benedict commented on CASSANDRA-8584:

[~aweisberg]: your patch changes the behaviour of the logging of the commit log sync, so that
we drop information. Our NoSpamLogger should perhaps have a ticket system, so that if we get
the right to log we know it (and can reset)? Previously every 5m we printed an aggregation
of the problematic state and reset our counters; now we print and reset without knowing if
the data got printed. So the problem of CL being behind on sync could be much worse than an
operator realises.

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>                 Key: CASSANDRA-8584
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Ariel Weisberg
>            Priority: Trivial
>             Fix For: 2.1.x
>         Attachments: 8584_v1.txt,, nospamlogger.txt
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.

This message was sent by Atlassian JIRA

View raw message