cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8465) Phase 1: Break static methods into classes
Date Thu, 28 May 2015 16:00:23 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563155#comment-14563155
] 

Joshua McKenzie commented on CASSANDRA-8465:
--------------------------------------------

Pulling the unsingleton effort off this ticket. Conversion of StorageProxy into non-static
/ non-singleton would make it easier to test *other* classes that rely on it in isolation
which really won't help with testing this refactor. Additionally, after spending an hour prototyping
the removal the hit to code clarity from having to pass StorageProxy instances around to various
query and tracing, the temporal coupling on initialization that it introduces, and the added
coupling between various modules more than negates any benefit it might give us in isolation
in my opinion.

See CASSANDRA-7483 for a more thorough discussion of some of the above. If we do choose to
convert any of our Singletons it's going to have to be for a very good reason (i.e. major
pain point in testing) to outweigh the cost.

> Phase 1: Break static methods into classes
> ------------------------------------------
>
>                 Key: CASSANDRA-8465
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8465
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>             Fix For: 3.x
>
>
> 1:  Writes
> * Regular
> * Counter
> * RegularBatch
> * CounterBatch
> * AtomicBatch
> 2:  Reads
> * Regular
> * Range
> 3:  LightweightTransaction
> * Write
> * Read
> 4: Truncate



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message