cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Burroughs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6591) un-deprecate cache recentHitRate and expose in o.a.c.metrics
Date Thu, 28 May 2015 18:31:26 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563424#comment-14563424
] 

Chris Burroughs commented on CASSANDRA-6591:
--------------------------------------------

Note for my own sanity j6591-1.2-v3.txt applies cleanly to 2.0.

Benedict,  You would accept this patch with the 'misses' removed, correct?

> un-deprecate cache recentHitRate and expose in o.a.c.metrics
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-6591
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6591
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Burroughs
>            Assignee: Chris Burroughs
>            Priority: Minor
>         Attachments: j6591-1.2-v1.txt, j6591-1.2-v2.txt, j6591-1.2-v3.txt
>
>
> recentHitRate metrics were not added as part of CASSANDRA-4009 because there is not an
obvious way to do it with the Metrics library.  Instead hitRate was added as an all time measurement
since node restart.
> This does allow changes in cache rate (aka production performance problems)  to be detected.
 Ideally there would be 1/5/15 moving averages for the hit rate, but I'm not sure how to calculate
that.  Instead I propose updating recentHitRate on a fixed interval and exposing that as a
Gauge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message