cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Shuler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5969) Allow JVM_OPTS to be passed to sstablescrub
Date Tue, 19 May 2015 00:09:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549548#comment-14549548
] 

Michael Shuler commented on CASSANDRA-5969:
-------------------------------------------

https://github.com/stef1927/cassandra/commit/d3c3d2fa597fad6c10d5afd56c2453b5034b8b32.patch
looks good to me - I also do not have a mac to test with. I ran the utils on linux fine with
the default JVM_OPTS that we get from cassandra-env.sh. I didn't embellish or try to break
things with any funky options.

> Allow JVM_OPTS to be passed to sstablescrub
> -------------------------------------------
>
>                 Key: CASSANDRA-5969
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5969
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Adam Hattrell
>            Assignee: Stefania
>              Labels: lhf
>             Fix For: 2.0.x
>
>
> Can you add a feature request to pass JVM_OPTS to the sstablescrub script -- and other
places where java is being called? (Among other things, this lets us run java stuff with "-Djava.awt.headless=true"
on OS X so that Java processes don't pop up into the foreground -- i.e. we have a script that
loops over all CFs and runs sstablescrub, and without that flag being passed in the OS X machine
becomes pretty much unusable as it keeps switching focus to the java processes as they start.)
>  
> --- a/resources/cassandra/bin/sstablescrub
> +++ b/resources/cassandra/bin/sstablescrub
> @@ -70,7 +70,7 @@ if [ "x$MAX_HEAP_SIZE" = "x" ]; then
>      MAX_HEAP_SIZE="256M"
>  fi
>  
> -$JAVA -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
> +$JAVA $JVM_OPTS -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
>          -Dlog4j.configuration=log4j-tools.properties \
>          org.apache.cassandra.tools.StandaloneScrubber "$@"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message