Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 349F81084B for ; Wed, 29 Apr 2015 00:04:07 +0000 (UTC) Received: (qmail 69180 invoked by uid 500); 29 Apr 2015 00:04:07 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 69089 invoked by uid 500); 29 Apr 2015 00:04:07 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 68870 invoked by uid 99); 29 Apr 2015 00:04:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2015 00:04:06 +0000 Date: Wed, 29 Apr 2015 00:04:06 +0000 (UTC) From: "sankalp kohli (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9260) Threadpool in RepairSession is not shutdown on failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-9260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518392#comment-14518392 ] sankalp kohli commented on CASSANDRA-9260: ------------------------------------------ This patch also fixes a visibility bug in ActiveRepairService > Threadpool in RepairSession is not shutdown on failure > ------------------------------------------------------ > > Key: CASSANDRA-9260 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9260 > Project: Cassandra > Issue Type: Bug > Reporter: sankalp kohli > Assignee: sankalp kohli > Priority: Minor > Attachments: trunk_9260.txt > > > We are not closing taskExecutor in RepairSession if any RepairJob fails. The only way it will close is if a replica goes down and shutdown is called via IFailureDetectionEventListener. > If RepairJob fails due to say snapshot timing out, C* will not call shutdown on this pool. -- This message was sent by Atlassian JIRA (v6.3.4#6332)