cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremiah Jordan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-9084) Do not generate line number in logs
Date Tue, 21 Apr 2015 20:05:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505635#comment-14505635
] 

Jeremiah Jordan edited comment on CASSANDRA-9084 at 4/21/15 8:04 PM:
---------------------------------------------------------------------

This is a bad idea.  We don't log in the read or write paths.  And line numbers can be very
useful.  We should revert this.

If someone really cares they can turn it off themselves.  If you really care put a commented
out version in the log file with them off, and a comment telling a user why they might want
that.  We have enough log messages that are the same, that line numbers are useful.


was (Author: jjordan):
This is a bad idea.  We don't log in the read or write paths.  And line numbers can be very
useful.  We should revert this.

> Do not generate line number in logs
> -----------------------------------
>
>                 Key: CASSANDRA-9084
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9084
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Config
>            Reporter: Andrey
>            Assignee: Benedict
>            Priority: Minor
>
> According to logback documentation (http://logback.qos.ch/manual/layouts.html):
> {code}
> Generating the line number information is not particularly fast. Thus, its use should
be avoided unless execution speed is not an issue.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message