cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9029) Add support for rate limiting log statements
Date Fri, 03 Apr 2015 19:44:53 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394984#comment-14394984
] 

Benedict commented on CASSANDRA-9029:
-------------------------------------

I'm not sure we need all of the myriad accessors (so many different ways of providing the
timing interval, the logger, etc). I would personally pare it back to just the NoSpamStatement.
I particularly don't see a great deal of benefit to the provision of the current time, since
the clock semantics may not match, and we shouldn't be logging in code _that_ performance
sensitive. But no super strong feelings, and it looks like it works. +1

> Add support for rate limiting log statements
> --------------------------------------------
>
>                 Key: CASSANDRA-9029
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9029
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message