cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8766) SSTableRewriter opens all sstables as early before completing the compaction
Date Fri, 17 Apr 2015 16:07:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500096#comment-14500096
] 

Joshua McKenzie commented on CASSANDRA-8766:
--------------------------------------------

I believe we resolved this as part of CASSANDRA-8535:
{code:title=switchWriter}
// If early re-open is disabled, simply finalize the writer and store it
if (preemptiveOpenInterval == Long.MAX_VALUE)
{
      SSTableReader reader = writer.finish(SSTableWriter.FinishType.NORMAL, maxAge, -1);
      finishedReaders.add(reader);
}
{code}

> SSTableRewriter opens all sstables as early before completing the compaction
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8766
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8766
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Joshua McKenzie
>            Priority: Minor
>             Fix For: 2.1.5
>
>
> In CASSANDRA-8320, we made the rewriter call switchWriter() inside of finish(); in CASSANDRA-8124
was made switchWriter() open its data as EARLY. This combination means we no longer honour
disabling of early opening, which is potentially a problem on windows for the deletion of
the contents (which is why we disable early opening on Windows).
> I've commented on CASSANDRA-8124, as I suspect I'm missing something about this. Although
I have no doubt the old behaviour of opening as TMP file reduced the window for problems,
and opening as TMPLINK now does the same, it's not entirely clear to me its the right fix
(though it may be) since we shouldn't be susceptible to this window anyway? Either way, we
perhaps need to come up with something else, because this could potentially break windows
support. Perhaps if we simply did not swap in the TMPLINK file so that it never actually get
mapped, it would perhaps be enough. [~JoshuaMcKenzie], WDYT?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message