cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sankalp kohli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8327) snapshots taken before repair are not cleared if snapshot fails
Date Thu, 09 Apr 2015 00:25:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486409#comment-14486409
] 

sankalp kohli commented on CASSANDRA-8327:
------------------------------------------

I happen to find a place where snapshot is not being deleted. In RepairMessageVerbHandler.doVerb,
if we find that repair cannot proceed due to overlapping stables with existing repairs, we
should delete the snapshot. 

if (!Sets.intersection(currentlyRepairing, snapshottedSSSTables).isEmpty())
                    {
                        //Need to remove snapshot.
                        logger.error("Cannot start multiple repair sessions over the same
sstables");
                        throw new RuntimeException("Cannot start multiple repair sessions
over the same sstables");
                    }
This could be fixed as part of this bug. 

> snapshots taken before repair are not cleared if snapshot fails
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8327
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8327
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment: cassandra 2.0.10.71
>            Reporter: MASSIMO CELLI
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 3.0
>
>
> running repair service the following directory was created for the snapshots:
> drwxr-xr-x 2 cassandra cassandra 36864 Nov 5 07:47 073d16e0-64c0-11e4-8e9a-7b3d4674c508

> but the system.log reports the following error which suggests the snapshot failed:
> ERROR [RMI TCP Connection(3251)-10.150.27.78] 2014-11-05 07:47:55,734 StorageService.java
(line 2599) Repair session 073d16e0-64c0-11e4-8e9a-7b3d4674c508 for range (7530018576963469312,7566047373982433280]
failed with error java.io.IOException: Failed during snapshot creation. java.util.concurrent.ExecutionException:
java.lang.RuntimeException: java.io.IOException: Failed during snapshot creation. .... ERROR
[AntiEntropySessions:3312] 2014-11-05 07:47:55,731 RepairSession.java (line 288) [repair #073d16e0-64c0-11e4-8e9a-7b3d4674c508]
session completed with the following error java.io.IOException: Failed during snapshot creation.
> the problem is that the directory for the snapshots that fail are just left on the disk
and don't get cleaned up. They must be removed manually, which is not ideal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message