cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5969) Allow JVM_OPTS to be passed to sstablescrub
Date Fri, 24 Apr 2015 08:52:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510669#comment-14510669
] 

Stefania commented on CASSANDRA-5969:
-------------------------------------

I've attached a patch that adds JVM_OPTS without quotes to the scripts of the standalone tools.
I don't think it makes sense for client java programs. The Windows scripts already have %JVM_OPTS%
in them so nothing to change there. 

I tested only on Linux as I do not have OS X. 

I tried to use quotes but to no avail because when quoting an undefined variable, there are
two spaces and this confuses the java binary. For some reason without quotes the second space
is eliminated, I assume by the shell.

The only way to use quotes I was able to find was to do something as ugly as {{"$CLASSPATH
$JVM_OPTS"}}.

> Allow JVM_OPTS to be passed to sstablescrub
> -------------------------------------------
>
>                 Key: CASSANDRA-5969
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5969
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Adam Hattrell
>            Assignee: Stefania
>              Labels: lhf
>
> Can you add a feature request to pass JVM_OPTS to the sstablescrub script -- and other
places where java is being called? (Among other things, this lets us run java stuff with "-Djava.awt.headless=true"
on OS X so that Java processes don't pop up into the foreground -- i.e. we have a script that
loops over all CFs and runs sstablescrub, and without that flag being passed in the OS X machine
becomes pretty much unusable as it keeps switching focus to the java processes as they start.)
>  
> --- a/resources/cassandra/bin/sstablescrub
> +++ b/resources/cassandra/bin/sstablescrub
> @@ -70,7 +70,7 @@ if [ "x$MAX_HEAP_SIZE" = "x" ]; then
>      MAX_HEAP_SIZE="256M"
>  fi
>  
> -$JAVA -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
> +$JAVA $JVM_OPTS -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
>          -Dlog4j.configuration=log4j-tools.properties \
>          org.apache.cassandra.tools.StandaloneScrubber "$@"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message