cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject [3/6] cassandra git commit: comment Murmur incompatibility
Date Fri, 17 Apr 2015 16:24:44 GMT
comment Murmur incompatibility


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/724384ab
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/724384ab
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/724384ab

Branch: refs/heads/trunk
Commit: 724384ab05e4a6bf3cacb1732641968d37e8c391
Parents: 9bbcbf5
Author: Jonathan Ellis <jbellis@apache.org>
Authored: Fri Apr 17 11:23:46 2015 -0500
Committer: Jonathan Ellis <jbellis@apache.org>
Committed: Fri Apr 17 11:24:07 2015 -0500

----------------------------------------------------------------------
 src/java/org/apache/cassandra/utils/MurmurHash.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/724384ab/src/java/org/apache/cassandra/utils/MurmurHash.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/utils/MurmurHash.java b/src/java/org/apache/cassandra/utils/MurmurHash.java
index 9dcde6d..c02fdcc 100644
--- a/src/java/org/apache/cassandra/utils/MurmurHash.java
+++ b/src/java/org/apache/cassandra/utils/MurmurHash.java
@@ -24,8 +24,10 @@ import java.nio.ByteBuffer;
  * lookup. See http://murmurhash.googlepages.com/ for more details.
  *
  * hash32() and hash64() are MurmurHash 2.0.
- * hash3_x64_128() is MurmurHash 3.0.
  *
+ * hash3_x64_128() is *almost* MurmurHash 3.0.  It was supposed to match, but we didn't catch
a sign bug with
+ * the result that it doesn't.  Unfortunately, we can't change it now without breaking Murmur3Partitioner.
*
+ * 
  * <p>
  * The C version of MurmurHash 2.0 found at that site was ported to Java by
  * Andrzej Bialecki (ab at getopt org).


Mime
View raw message