Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA9ED1744E for ; Tue, 17 Mar 2015 17:17:40 +0000 (UTC) Received: (qmail 49712 invoked by uid 500); 17 Mar 2015 17:17:40 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 49680 invoked by uid 500); 17 Mar 2015 17:17:40 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 49662 invoked by uid 99); 17 Mar 2015 17:17:40 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 17:17:40 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8B459E0FC2; Tue, 17 Mar 2015 17:17:40 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: snazy@apache.org To: commits@cassandra.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: cassandra git commit: UDF shouldn't log errors at ERROR (change to DEBUG) Date: Tue, 17 Mar 2015 17:17:40 +0000 (UTC) Repository: cassandra Updated Branches: refs/heads/trunk 287366752 -> ac9ccfdf7 UDF shouldn't log errors at ERROR (change to DEBUG) Patch by Robert Stupp for CASSANDRA-8980 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ac9ccfdf Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ac9ccfdf Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ac9ccfdf Branch: refs/heads/trunk Commit: ac9ccfdf7c1d06cf01eeb84561a7c514674cc3b8 Parents: 2873667 Author: Robert Stupp Authored: Tue Mar 17 18:15:52 2015 +0100 Committer: Robert Stupp Committed: Tue Mar 17 18:15:52 2015 +0100 ---------------------------------------------------------------------- .../apache/cassandra/cql3/functions/JavaSourceUDFFactory.java | 4 ++-- src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra/blob/ac9ccfdf/src/java/org/apache/cassandra/cql3/functions/JavaSourceUDFFactory.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/cql3/functions/JavaSourceUDFFactory.java b/src/java/org/apache/cassandra/cql3/functions/JavaSourceUDFFactory.java index 3033d98..1abb40b 100644 --- a/src/java/org/apache/cassandra/cql3/functions/JavaSourceUDFFactory.java +++ b/src/java/org/apache/cassandra/cql3/functions/JavaSourceUDFFactory.java @@ -202,7 +202,7 @@ public final class JavaSourceUDFFactory * } * catch (Throwable t) * { - * logger.info("Invocation of function '{}' failed", this, t); + * logger.debug("Invocation of function '{}' failed", this, t); * if (t instanceof VirtualMachineError) * throw (VirtualMachineError)t; * throw org.apache.cassandra.exceptions.FunctionExecutionException.build(this, t); @@ -244,7 +244,7 @@ public final class JavaSourceUDFFactory " }\n" + " catch (Throwable t)\n" + " {\n" + - " logger.info(\"Invocation of function '{}' failed\", this, t);\n" + + " logger.debug(\"Invocation of function '{}' failed\", this, t);\n" + // handle OutOfMemoryError and other fatals not here! " if (t instanceof VirtualMachineError)\n" + " throw (VirtualMachineError)t;\n" + http://git-wip-us.apache.org/repos/asf/cassandra/blob/ac9ccfdf/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java b/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java index 06452e6..4fe6ac9 100644 --- a/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java +++ b/src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDF.java @@ -139,7 +139,7 @@ public class ScriptBasedUDF extends UDFunction } catch (RuntimeException | ScriptException e) { - logger.info("Execution of UDF '{}' failed", name, e); + logger.debug("Execution of UDF '{}' failed", name, e); throw FunctionExecutionException.create(this, e); } }