Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 12 Mar 2015 21:16:38 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12760569.1418161858000.79788.1426194998640@Atlassian.JIRA>
In-Reply-To: <JIRA.12760569.1418161858000@Atlassian.JIRA>
References: <JIRA.12760569.1418161858000@Atlassian.JIRA>
 <JIRA.12760569.1418161858684@arcas>
Subject: [jira] [Commented] (CASSANDRA-8449) Allow zero-copy reads again
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359434#comment-14359434 ] 

Benedict commented on CASSANDRA-8449:
-------------------------------------

bq. -carrot- casus belli

FTFY :)

> Allow zero-copy reads again
> ---------------------------
>
>                 Key: CASSANDRA-8449
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8449
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: T Jake Luciani
>            Assignee: T Jake Luciani
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.0
>
>
> We disabled zero-copy reads in CASSANDRA-3179 due to in flight reads accessing a ByteBuffer when the data was unmapped by compaction.  Currently this code path is only used for uncompressed reads.
> The actual bytes are in fact copied to the client output buffers for both netty and thrift before being sent over the wire, so the only issue really is the time it takes to process the read internally.  
> This patch adds a slow network read test and changes the tidy() method to actually delete a sstable once the readTimeout has elapsed giving plenty of time to serialize the read.
> Removing this copy causes significantly less GC on the read path and improves the tail latencies:
> http://cstar.datastax.com/graph?stats=c0c8ce16-7fea-11e4-959d-42010af0688f&metric=gc_count&operation=2_read&smoothing=1&show_aggregates=true&xmin=0&xmax=109.34&ymin=0&ymax=5.5


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)