Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 4 Mar 2015 17:10:04 +0000 (UTC)
From: "Joshua McKenzie (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12757959.1417005032000.76599.1425489004839@Atlassian.JIRA>
In-Reply-To: <JIRA.12757959.1417005032000@Atlassian.JIRA>
References: <JIRA.12757959.1417005032000@Atlassian.JIRA>
 <JIRA.12757959.1417005032350@arcas>
Subject: [jira] [Commented] (CASSANDRA-8375) Cleanup of generics in bounds
 serialization
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347161#comment-14347161 ] 

Joshua McKenzie commented on CASSANDRA-8375:
--------------------------------------------

Sorry for the delay on this - looks good. Could we get a rebase to current trunk?

> Cleanup of generics in bounds serialization
> -------------------------------------------
>
>                 Key: CASSANDRA-8375
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8375
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: 8375.patch
>
>
> There is currently a single serializer for {{AbstractBounds}} applied to both {{Token}} and {{RowPosition}} ranges and bounds. This serializer does not know which kind of bounds it needs to work with, which causes some necessarily unsafe conversions and needs extra code in all bounds types ({{toRowBounds}}/{{toTokenBounds}}) to make the conversions safe, the application of which can be easily forgotten.
> As all users of this serialization know in advance the kind of range they want to serialize, this can be replaced by simpler type-specific serialization.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)