Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 30 Mar 2015 23:58:53 +0000 (UTC)
From: "Stefania (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12735584.1408574546000.74533.1427759933587@Atlassian.JIRA>
In-Reply-To: <JIRA.12735584.1408574546000@Atlassian.JIRA>
References: <JIRA.12735584.1408574546000@Atlassian.JIRA>
 <JIRA.12735584.1408574546671@arcas>
Subject: [jira] [Commented] (CASSANDRA-7807) Push notification when tracing
 completes for an operation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387643#comment-14387643 ] 

Stefania commented on CASSANDRA-7807:
-------------------------------------

Yes that's clearly the case. But then it means that in {{createTracingSession()}} we can rely on {{preparedTracingSession}} - which is only set when {{isTracingRequested}} is true, to inform us if it was actually the client that initiated the tracing request, which is in fact what we are looking at to determine if the boolean should be false or true. So the reason for preferring a boolean instead of simply not forwarding the connection is style / safety? But it did cost us 5 overloads of {{newSession()}} sadly.  

Anyway, this patch is now definitely +1 to commit, well done! 


> Push notification when tracing completes for an operation
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-7807
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7807
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Robert Stupp
>            Priority: Minor
>              Labels: client-impacting, protocolv4
>             Fix For: 3.0
>
>         Attachments: 7807-v2.txt, 7807-v3.txt, 7807-v4.txt, 7807.txt
>
>
> Tracing is an asynchronous operation, and drivers currently poll to determine when the trace is complete (in a loop with sleeps).  Instead, the server could push a notification to the driver when the trace completes.
> I'm guessing that most of the work for this will be around pushing notifications to a single connection instead of all connections that have registered listeners for a particular event type.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)