cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-8994) Make keyspace handling in FunctionName less fragile
Date Thu, 19 Mar 2015 13:51:38 GMT
Sylvain Lebresne created CASSANDRA-8994:
-------------------------------------------

             Summary: Make keyspace handling in FunctionName less fragile
                 Key: CASSANDRA-8994
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8994
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
            Priority: Minor
             Fix For: 3.0


{{FunctionName}} keyspace field can be null because it can be omitted by the user (in which
case we search both the system keyspace and the one of the statement). The handling of that
is imo a tad fragile: the {{equals}} method should typically probably complain if one of its
operand has no keyspace since in that case, we can't really properly answer. The code currently
work around that in {{Functions}} by avoiding {{equals}} when this matter but it would still
be pretty easy to get that wrong, especially since {{FunctionName}} is used in maps.  For
instance, you could argue that {{Functions#find}} is broken if its argument has no keyspace
(it happens to be only use when that's not the case, but again, pretty easy to get wrong in
the future).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message