cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Björn Hachmann (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-8993) EffectiveIndexInterval calculation is incorrect
Date Tue, 24 Mar 2015 15:02:54 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377981#comment-14377981
] 

Björn Hachmann edited comment on CASSANDRA-8993 at 3/24/15 3:02 PM:
--------------------------------------------------------------------

Hi [~benedict],

as I do not completely understand the discussion in this ticket, I ask myself, if the attached
patch might also be a cure for the NPEs reported for CASSANDRA-8851? 

Thank you + Kind regards!


was (Author: hachmann):
Hi @Benedict,

as I do not completely understand the discussion in this ticket, I ask myself, if the attached
patch might also be a cure for the NPEs reported for CASSANDRA-8851? 

Thank you + Kind regards!

> EffectiveIndexInterval calculation is incorrect
> -----------------------------------------------
>
>                 Key: CASSANDRA-8993
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8993
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Blocker
>             Fix For: 2.1.4
>
>         Attachments: 8993.txt
>
>
> I'm not familiar enough with the calculation itself to understand why this is happening,
but see discussion on CASSANDRA-8851 for the background. I've introduced a test case to look
for this during downsampling, but it seems to pass just fine, so it may be an artefact of
upgrading.
> The problem was, unfortunately, not manifesting directly because it would simply result
in a failed lookup. This was only exposed when early opening used firstKeyBeyond, which does
not use the effective interval, and provided the result to getPosition().
> I propose a simple fix that ensures a bug here cannot break correctness. Perhaps [~thobbs]
can follow up with an investigation as to how it actually went wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message