cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-8976) Remove BINARY from DROPPABLE_VERBS
Date Tue, 17 Mar 2015 09:22:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364806#comment-14364806
] 

Dave Brosius edited comment on CASSANDRA-8976 at 3/17/15 9:22 AM:
------------------------------------------------------------------

Verb.BINARY has not been used at all since 1.1. One assumes you are not allowed to run mixed
1.1/3.0 cluster, and so it can be removed from DROPPABLE_VERBS but it would seem the enum
itself has to remain otherwise it will mess up 2.1 <-> 3.0 serialization of  Verbs,
as serialization is done by ordinal.

so the patch removes it from DROPPABLE_VERBS.


was (Author: dbrosius):
Verb.BINARY has not been used at all since 1.1. One assumes you are not allowed to run mixed
1.1/3.0 cluster, and so it can be removed from DROPPABLE_VERBS but it would seem the enum
itself has to remain otherwise it will mess up serialization of 2.1 <-> 3.0 Verbs, as
serialization is done by ordinal.

so the patch removes it from DROPPABLE_VERBS.

> Remove BINARY from DROPPABLE_VERBS
> ----------------------------------
>
>                 Key: CASSANDRA-8976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8976
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Chris Lohfink
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: lhf
>             Fix For: 3.0
>
>         Attachments: binary.txt
>
>
> The deprecated {{Verb.BINARY}} type has been listed in {{MessagingService.DROPPABLE_VERBS}}
for awhile even though it has no value.  This is pretty irrelevant but it shows up in results
to {{nodetool tpstats}} which may seem to be related to the binary protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message