cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8850) clean up options syntax for create/alter role
Date Thu, 05 Mar 2015 16:59:39 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349084#comment-14349084
] 

Sam Tunnicliffe commented on CASSANDRA-8850:
--------------------------------------------

I've rebased & pushed a couple of commits to a [branch | https://github.com/beobal/cassandra/tree/8850]

The first makes the options syntax on {{(CREATE|ALTER) ROLE}} consistent with other CQL statements.
It also makes the {{IRoleManager}} interface a little more strongly typed by making {{RoleOptions}}
more useful and using it in place of the generic {{Map<Option, Object>}} in {{createRole}}
and {{alterRole}}.

The second commit enforces the string literal constraint on role names where possible. {{ListPermissions}}
is really the only place where it's really ambiguous. I've mentioned in the comments, we will
be able to simplify the grammar again if/when we remove support for the old user syntax.

> clean up options syntax for create/alter role 
> ----------------------------------------------
>
>                 Key: CASSANDRA-8850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8850
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 8850-v2.txt, 8850.txt
>
>
> {{CREATE/ALTER ROLE}} syntax would be improved by using {{WITH}} and {{AND}} in a way
more consistent with other statements.
> e.g. {{CREATE ROLE foo WITH LOGIN AND SUPERUSER AND PASSWORD 'password'}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message