cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-8592) Add WriteFailureException
Date Wed, 11 Mar 2015 20:49:38 GMT


Tyler Hobbs commented on CASSANDRA-8592:

bq. This means changing the signature of every verb handler, are you sure?

Yes, I'm fine with that (mostly because there's only one caller).

bq. Because this latter does not extend IMutation we need to keep AbstractWriteResponseHandler
generic. I tried to fix all the warnings in StorageProxy. Let me know if you see more.

Makes sense, thanks.  I think the warnings are good now.

bq. BTW, do you guys perhaps have a different policy to leave alone unrelated things such
as compiler warnings?

It's not a big deal to fix them in the same patch if they're small changes.  If they're large,
it's nice to split those changes into a separate patch or commit to keep the diff clear.

> Add WriteFailureException
> -------------------------
>                 Key: CASSANDRA-8592
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>              Labels: client-impacting
>             Fix For: 3.0
> Similar to what CASSANDRA-7886 did for reads, we should add a WriteFailureException and
have replicas signal a failure while handling a write to the coordinator.

This message was sent by Atlassian JIRA

View raw message